Fix server fetches a URL the caller controls in SolidStart

An outbound HTTP request is made to a URL that came from the caller. The server can reach hosts the caller cannot - cloud metadata endpoints, internal admin services, databases bound to localhost - so this turns the server into a proxy into its own network. Validate the destination against an allowlist before fetching it.

high likely SolidStart CWE-918 / OWASP A10:2021

The vulnerable pattern in SolidStart

HIGH likely Server fetches a URL the caller controls A10:2021 src/routes/api/import.ts:9:26 7 │ 8 │ // ssrf: the server fetches whatever host the caller names. 9 │ const upstream = await fetch(body.sourceUrl as string) │ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ destination chosen by the caller 10 │ 11 │ // ssrf: axios reaches a second caller-controlled host.

This finding comes from the SolidStart fixture in the owlwarden test suite, in /api/import. The destination of this request comes from the caller, so they choose which host the server connects to. That includes hosts they cannot reach themselves: the cloud metadata endpoint that hands out IAM credentials, internal services that skip authentication because they are 'not exposed', and anything bound to localhost.

The corrected handler

Validate the URL in the API route before fetching, and refuse redirects.

const url = assertAllowedUrl(body.url)
const upstream = await fetch(url, { redirect: 'error' })

On a different runtime

The fix above is written for the runtime SolidStart usually runs on. These are the runtimes where it would not run at all - an import that does not exist, or an API the host does not have - and what to write instead.

Workers and other fetch-API runtimes

redirect: 'error' is not honoured on this runtime. Use redirect: 'manual' and refuse the response yourself, or an allowlisted host can redirect you to one that is not.

const url = assertAllowedUrl(input)
const upstream = await fetch(url, { redirect: 'manual' })
if (upstream.status >= 300 && upstream.status < 400) {
  throw new Error('refusing to follow a redirect from an allowlisted host')
}

If you are not using SolidStart

Check the destination against an allowlist of hosts before fetching it. Blocklists do not work here: DNS rebinding, redirects, and IPv6-mapped addresses all defeat them.

Check your own repository

npx owlwarden scan
npx owlwarden explain ssrf

Runs on your machine. No account, no telemetry, no network unless you ask. In CI, SARIF uploads to code scanning and the exit code is the gate.

Other SolidStart checks

Rules with a tested SolidStart example.

ssrf for every framework / All rules / owlwarden