Fix redirect target comes from the caller in Remix

The destination of a redirect is taken from the request without being checked. An attacker can send a link that starts with your domain and ends on theirs, which is what makes a phishing page credible - and in an OAuth callback it hands the authorisation code to whoever asked. Resolve the target against your own origin and refuse anything else.

medium likely Remix CWE-601 / OWASP A01:2021

The vulnerable pattern in Remix

MEDIUM likely Redirect target comes from the caller A01:2021 app/routes/api.users.ts:86:12 84 │ // open-redirect 85 │ if (next) { 86 │ return redirect(next) │ ~~~~~~~~~~~~~~ destination chosen by the caller 87 │ }

This finding comes from the Remix fixture in the owlwarden test suite, in /api/users. The whole redirect target comes from the request, so a link to this endpoint can send a visitor anywhere. The URL they click genuinely belongs to you, which is what makes the page they land on convincing - and on an OAuth callback the authorisation code goes with them.

The corrected handler

Validate before calling redirect(); the request URL's origin is the base.

import { redirect } from '@remix-run/node'

export async function loader({ request }: LoaderFunctionArgs) {
  const url = new URL(request.url)
  const next = url.searchParams.get('next')
  return redirect(safeRedirect(next, url.origin))
}

If you are not using Remix

Resolve the target against your own origin and refuse anything that lands elsewhere. Do not use a startsWith('/') check: '//evil.com' passes it and leaves the site.

Check your own repository

npx owlwarden scan
npx owlwarden explain open-redirect

Runs on your machine. No account, no telemetry, no network unless you ask. In CI, SARIF uploads to code scanning and the exit code is the gate.

Other Remix checks

Rules with a tested Remix example.

open-redirect for every framework / All rules / owlwarden