Fix cross-origin policy accepts any origin in Sails.js
The CORS configuration accepts requests from any origin. Combined with credentials this lets any site a logged-in user visits make authenticated calls to the API and read the responses. Without credentials it may be intentional for a public API - the finding says which case it found.
medium likely Sails.js CWE-942 / OWASP A05:2021
The vulnerable pattern in Sails.js
This finding comes from the Sails.js fixture in the owlwarden test
suite, in /auth.
Any origin may call this API and read the response. That is a deliberate choice for a public endpoint and a mistake for anything behind a session - nothing in the source says which this is, so it is reported for you to decide.
The corrected handler
Give sails.config.security.cors an explicit origin list.
// config/security.js
module.exports.security = {
cors: {
allRoutes: true,
allowOrigins: ['https://app.example.com'],
allowCredentials: true,
},
}If you are not using Sails.js
Replace the wildcard with the origins that actually need access, and only send credentials to those.
Check your own repository
npx owlwarden scan
npx owlwarden explain cors-permissiveRuns on your machine. No account, no telemetry, no network unless you ask. In CI, SARIF uploads to code scanning and the exit code is the gate.
Other Sails.js checks
Rules with a tested Sails.js example.
- hardcoded-secret high Credential hardcoded in source
- insecure-cookie medium Cookie set without its protective attributes
- install-lifecycle-script medium Package declares an install-time script
- open-redirect medium Redirect target comes from the caller
- security-headers-missing medium Security headers are not configured
- sensitive-data-logged medium Sensitive data written to a log
- sql-injection high SQL query built by string interpolation
- ssrf high Server fetches a URL the caller controls
- stack-trace-leak high Stack trace leaked in error response
- weak-crypto high Broken cryptographic primitive protecting a secret